linux-kernel - Re: [PATCH v7 3/6] Documentation: Add ABI doc for attributes of LJCA device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Apr 2023 13:10:33 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     "Ye, Xiang" <xiang.ye@...el.com>, Oliver Neukum <oneukum@...e.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Matthias Kaehlcke <mka@...omium.org>,
        Lee Jones <lee@...nel.org>, Wolfram Sang <wsa@...nel.org>,
        Tyrone Ting <kfting@...oton.com>,
        Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, linux-usb@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-gpio@...r.kernel.org,
        srinivas.pandruvada@...el.com, heikki.krogerus@...ux.intel.com,
        andriy.shevchenko@...ux.intel.com, sakari.ailus@...ux.intel.com,
        zhifeng.wang@...el.com, wentong.wu@...el.com, lixu.zhang@...el.com
Subject: Re: [PATCH v7 3/6] Documentation: Add ABI doc for attributes of LJCA
 device

On 10.04.23 12:44, Ye, Xiang wrote:

Hi,

>> do we really want each driver to have its own attribute for that?
>> It seems to me that that should be unified.
> Three ABI entries are added in this patch: ljca_version, ljca_trace_level,
> and ljca_enable_dfu. The first two items are specified for LJCA device and
> I think they can be kept in sysfs-bus-usb-devices-ljca.
> 
> But for ljca_enable_dfu, I didn't see a unified DFU entry in sys-bus-usb.
> I am not sure whether other USB devices have similar DFU mode or not.
> 
> Any suggestions?

What exactly does this attribute do?
Is it in addition to the normal DFU_DETACH + reset sequence, is it
needed for DFU_DETACH to work, does it enable the
DFU class interface descriptor?

A point of DFU is rather that the capability should be announced
via descriptors. The answer would depend on what exactly this
attribute does.

	Regards
		Oliver