[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <98bb3388-d671-dcf3-0247-649a702b5e11@linux.intel.com>
Date: Wed, 12 Apr 2023 13:10:22 +0100
From: Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>
To: Christian König <christian.koenig@....com>,
Rob Clark <robdclark@...il.com>,
dri-devel@...ts.freedesktop.org
Cc: linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
Boris Brezillon <boris.brezillon@...labora.com>,
Christopher Healy <healych@...zon.com>,
Emil Velikov <emil.l.velikov@...il.com>,
Rob Clark <robdclark@...omium.org>,
Alex Deucher <alexander.deucher@....com>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@...ts.freedesktop.org>,
Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@....com>,
Christian Gmeiner <christian.gmeiner@...il.com>,
"moderated list:DRM DRIVERS FOR VIVANTE GPU IP"
<etnaviv@...ts.freedesktop.org>, Evan Quan <evan.quan@....com>,
Guchun Chen <guchun.chen@....com>,
Hawking Zhang <Hawking.Zhang@....com>,
intel-gfx@...ts.freedesktop.org,
"open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
Mario Limonciello <mario.limonciello@....com>,
Michel Dänzer <mdaenzer@...hat.com>,
Russell King <linux+etnaviv@...linux.org.uk>,
Sean Paul <sean@...rly.run>,
Shashank Sharma <shashank.sharma@....com>,
Tvrtko Ursulin <tvrtko.ursulin@...el.com>,
YiPeng Chai <YiPeng.Chai@....com>
Subject: Re: [PATCH v3 0/7] drm: fdinfo memory stats
On 12/04/2023 10:34, Christian König wrote:
> Am 12.04.23 um 00:56 schrieb Rob Clark:
>> From: Rob Clark <robdclark@...omium.org>
>>
>> Similar motivation to other similar recent attempt[1]. But with an
>> attempt to have some shared code for this. As well as documentation.
>>
>> It is probably a bit UMA-centric, I guess devices with VRAM might want
>> some placement stats as well. But this seems like a reasonable start.
>>
>> Basic gputop support: https://patchwork.freedesktop.org/series/116236/
>> And already nvtop support: https://github.com/Syllo/nvtop/pull/204
>>
>> [1] https://patchwork.freedesktop.org/series/112397/
>
> I think the extra client id looks a bit superfluous since the ino of the
> file should already be unique and IIRC we have been already using that one.
Do you mean file_inode(struct drm_file->filp)->i_ino ? That one would be
the same number for all clients which open the same device node so
wouldn't work.
I also don't think the atomic_add_return for client id works either,
since it can alias on overflow.
In i915 I use an xarray and __xa_alloc_cyclic.
Regards,
Tvrtko
Powered by blists - more mailing lists