[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e129b3ff-90b1-3df7-871e-09fba0a960f4@collabora.com>
Date: Wed, 12 Apr 2023 15:17:21 +0200
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Alexandre Mergnat <amergnat@...libre.com>, matthias.bgg@...il.com
Cc: p.zabel@...gutronix.de, airlied@...il.com, daniel@...ll.ch,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
jassisinghbrar@...il.com, chunfeng.yun@...iatek.com,
vkoul@...nel.org, kishon@...nel.org, thierry.reding@...il.com,
u.kleine-koenig@...gutronix.de, chunkuang.hu@...nel.org,
ck.hu@...iatek.com, jitao.shi@...iatek.com,
xinlei.lee@...iatek.com, houlong.wei@...iatek.com,
dri-devel@...ts.freedesktop.org,
linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-phy@...ts.infradead.org, linux-pwm@...r.kernel.org,
kernel@...labora.com, phone-devel@...r.kernel.org,
~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 02/27] dt-bindings: phy: mediatek,dsi-phy: Add compatible
for MT6795 Helio X10
Il 12/04/23 15:12, Alexandre Mergnat ha scritto:
> On 12/04/2023 15:03, AngeloGioacchino Del Regno wrote:
>> Il 12/04/23 14:59, Alexandre Mergnat ha scritto:
>>> On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote:
>>>> Add a compatible string for MediaTek Helio X10 MT6795: this SoC uses
>>>> the same DSI PHY as MT8173.
>>>>
>>>> Signed-off-by: AngeloGioacchino Del Regno
>>>> <angelogioacchino.delregno@...labora.com>
>>>> ---
>>>> Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
>>>> b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
>>>> index 26f2b887cfc1..a9f78344efdb 100644
>>>> --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
>>>> +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
>>>> @@ -24,6 +24,10 @@ properties:
>>>> - enum:
>>>> - mediatek,mt7623-mipi-tx
>>>> - const: mediatek,mt2701-mipi-tx
>>>> + - items:
>>>> + - enum:
>>>> + - mediatek,mt6795-mipi-tx
>>>> + - const: mediatek,mt8173-mipi-tx
>>>
>>> AFAIK, it should be:
>>> - items:
>>> - const: mediatek,mt6795-mipi-tx
>>> - const: mediatek,mt8173-mipi-tx
>>>
>>> Since it isn't respected above for mt7623, it may be tolerated.
>>> Please, take this comment as a suggestion, isn't a NAK from me.
>>>
>>
>> First of all, Thanks!
>> I want to explain, though, the reason for that.
>>
>> If you check all the commits, on some I did it as you just proposed, while
>> on some others I did it with an enum before const: that's simply because I
>> *totally expect* some to grow, while others (const - const) I was either
>> unsure, or totally *not* expecting them to grow soon!
>
>
> That's what I thought. IMHO, if someone add another compat later, he will be on
> charge to change the const by enum front of your "mediatek,mt6795-mipi-tx". But my
> opinion is probably not the most popular.
>
> I will not make the same feedback for the other patches in this series.
>
I honestly don't know what's the most popular opinion about that... but whatever,
in any case... just want to make sure to communicate that I don't really have
strong opinions about doing it one way or the other.
The arguments in favor and against that are probably 1:1... :-D
Cheers!
Angelo
Powered by blists - more mailing lists