linux-kernel - Re: [PATCH] phy: smsc: Implement .aneg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7330ff6d-665f-4c79-975d-6e023c781237@lunn.ch>
Date:   Wed, 12 Apr 2023 15:34:33 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Lukasz Majewski <lukma@...x.de>
Cc:     Simon Horman <simon.horman@...igine.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: smsc: Implement .aneg_done callback for LAN8720Ai

> > This actually seems like a fix. So it should probably be based on net,
> > and have a Fixes: tag.
> 
> I've rebased it on the newest vanila kernel.

Please see the netdev FAQ. It talks about the two git trees used for
networking.

> It turned out that this IC has a dedicated bit (in vendor specific
> register) to show explicitly if auto neg is done.
> 
> > 
> > Lukasz, how does this bit differ to the one in BMSR? 
> 
> In the BMSR - bit 5 (Auto Negotiate Complete) - shows the same kind of
> information.
> 
> The only difference is that this bit is described as "Auto
> Negotiate Complete" and the bit in this patch indicates "Auto
> Negotiation Done".
> 
> > Is the BMSR bit
> > broken? 
> 
> This bit works as expected.

I would avoid the vendor bit, if it has no benefit. A lot of
developers understand the BMSR bit, where as very few know this vendor
bit. BMSR can probably be handled with generic code, where as the
vendor bit requires vendor specific code etc.

    Andrew