linux-kernel - Re: [PATCH] tools/nolibc: Fix build of stdio.h due to header ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDg3K2nI+5l6as/L@1wt.eu>
Date:   Thu, 13 Apr 2023 19:08:59 +0200
From:   Willy Tarreau <w@....eu>
To:     Mark Brown <broonie@...nel.org>,
        "Paul E. McKenney" <paulmck@...nel.org>
Cc:     Thomas Weißschuh <linux@...ssschuh.net>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] tools/nolibc: Fix build of stdio.h due to header ordering

Hi Mark,

Sorry for this issue, I don't know why it didn't trigger in our tests,
maybe due to the includes being explicit in the test program.

On Thu, Apr 13, 2023 at 05:26:32PM +0100, Mark Brown wrote:
> When we added fd based file streams we created references to STx_FILENO in
> stdio.h but these constants are declared in unistd.h which is the last file
> included by the top level nolibc.h meaning those constants are not defined
> when we try to build stdio.h. This causes programs using nolibc.h to fail
> to build.
> 
> Reorder the headers to avoid this issue.
> 
> Fixes: d449546c957f ("tools/nolibc: implement fd-based FILE streams")
> Signed-off-by: Mark Brown <broonie@...nel.org>
Acked-by: Willy Tarreau <w@....eu>

Paul, the commit above is in your rcu/next branch but fortunately not
in the series you've prepared for 6.4, so it will be sufficient to pick
it on top of next and you can take it directly if you want.

Thanks!
Willy