linux-kernel - Re: [PATCH] crypto: ixp4xx - Do not check word size when compile testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYnXdFky0z0EEsmbQ5hbs=J=oRb+3vAcuDpWaLTh1kxmQ@mail.gmail.com>
Date:   Thu, 13 Apr 2023 22:12:06 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Tom Zanussi <tom.zanussi@...ux.intel.com>, clabbe@...libre.com,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] crypto: ixp4xx - Do not check word size when compile testing

On Sun, Apr 9, 2023 at 9:47 AM Herbert Xu <herbert@...dor.apana.org.au> wrote:
> On Fri, Apr 07, 2023 at 02:37:44PM -0500, Tom Zanussi wrote:
> > COMPILE_TEST was added during the move to drivers/crypto/intel/ but
> > shouldn't have been as it triggers a build bug when not compiled by
> > the target compiler.  So remove it to match the original.
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Link: https://lore.kernel.org/oe-kbuild-all/202304061846.G6cpPXiQ-lkp@intel.com/
> > Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> > ---
> >  drivers/crypto/intel/ixp4xx/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> We could also fix it by making the BUILD_BUG_ON conditional:
>
> ---8<---
> The BUILD_BUG_ON preventing compilation on foreign architectures
> should be disabled when we're doing compile testing.
>
> Fixes: 1bc7fdbf2677 ("crypto: ixp4xx - Move driver to...")
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304061846.G6cpPXiQ-lkp@intel.com/
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

This fix is more elegant I think, as it keeps the compile coverage.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij