linux-kernel - Re: [PATCH] clk: starfive: Avoid casting iomem pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <558d22a8848f2f026f272fdc0528424d.sboyd@kernel.org>
Date:   Thu, 13 Apr 2023 15:01:02 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Conor Dooley <conor@...nel.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        patches@...ts.linux.dev, Tommaso Merciai <tomm.merciai@...il.com>,
        Emil Renner Berthing <emil.renner.berthing@...onical.com>,
        Hal Feng <hal.feng@...rfivetech.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Xingyu Wu <xingyu.wu@...rfivetech.com>
Subject: Re: [PATCH] clk: starfive: Avoid casting iomem pointers

Quoting Conor Dooley (2023-04-13 14:26:56)
> > @@ -335,26 +338,32 @@ static void jh7110_reset_unregister_adev(void *_adev)
> >       struct auxiliary_device *adev = _adev;
> >  
> >       auxiliary_device_delete(adev);
> > +     auxiliary_device_uninit(adev);
> 
> Huh, I think you didn't explicitly mention this one, but it's actually
> part of the UAF fix AFAICT?
> 
> When I did the aux device stuff for the clk-mpfs driver, I copied from
> peci as there were almost no examples of aux dev stuff in-tree.
> It looks like subsequently to me starting development, this fix landed:
> 1c11289b34ab ("peci: cpu: Fix use-after-free in adev_release()")
> 
> It similarly moves the uninit() to the release callback...
> 
> I think I need the below (whitespace damaged):

Yeah that looks better. Care to send a proper patch for it?

> diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk-mpfs.c
> index 4f0a19db7ed7..cc5d7dee59f0 100644
> --- a/drivers/clk/microchip/clk-mpfs.c
> +++ b/drivers/clk/microchip/clk-mpfs.c
> @@ -374,14 +374,13 @@ static void mpfs_reset_unregister_adev(void *_adev)
>         struct auxiliary_device *adev = _adev;
>  
>         auxiliary_device_delete(adev);
> +       auxiliary_device_uninit(adev);
>  }
>  
>  static void mpfs_reset_adev_release(struct device *dev)
>  {
>         struct auxiliary_device *adev = to_auxiliary_dev(dev);
>  
> -       auxiliary_device_uninit(adev);
> -
>         kfree(adev);
>  }
> 
> Anyways, for this patch:
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> 

Thanks.