linux-kernel - Re: [PATCH v1] clk: microchip: fix potential UAF in auxdev release callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b602852596974df384b2d7088cadd64.sboyd@kernel.org>
Date:   Thu, 13 Apr 2023 15:43:45 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Conor Dooley <conor@...nel.org>
Cc:     conor@...nel.org, Conor Dooley <conor.dooley@...rochip.com>,
        stable@...r.kernel.org,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        Michael Turquette <mturquette@...libre.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] clk: microchip: fix potential UAF in auxdev release callback

Quoting Conor Dooley (2023-04-13 15:20:45)
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> Similar to commit 1c11289b34ab ("peci: cpu: Fix use-after-free in
> adev_release()"), the auxiliary device is not torn down in the correct
> order. If auxiliary_device_add() fails, the release callback will be
> called twice, resulting in a UAF. Due to timing, the auxdev code in this
> driver "took inspiration" from the aforementioned commit, and thus its
> bugs too!
> 
> Moving auxiliary_device_uninit() to the unregister callback instead
> avoids the issue.
> 
> CC: stable@...r.kernel.org
> Fixes: b56bae2dd6fd ("clk: microchip: mpfs: add reset controller")
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---

Applied to clk-next