linux-kernel - Re: [PATCH v2 3/3] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd2fd84c-78f2-e629-ea47-6e40ea5dad23@linaro.org>
Date:   Fri, 14 Apr 2023 01:38:42 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Andrew Halaney <ahalaney@...hat.com>, linux-kernel@...r.kernel.org
Cc:     agross@...nel.org, andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sa8155p-adp: Remove unneeded
 rgmii_phy information



On 13.04.2023 21:40, Andrew Halaney wrote:
> Using interrupts-extended already indicates what the interrupt-parent
> is, so drop the explicit interrupt-parent.
> 
> The comment about this being the phy-intr is not helpful either, since
> this is the only interrupt in the phy node.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
> 
> Changes since v1:
>     * New patch (Konrad)
> 
>  arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index ac52a8dfeba1..b65e0203d783 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -361,8 +361,7 @@ rgmii_phy: phy@7 {
>  			compatible = "ethernet-phy-ieee802.3-c22";
>  			reg = <0x7>;
>  
> -			interrupt-parent = <&tlmm>;
> -			interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */
> +			interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>;
>  			device_type = "ethernet-phy";
>  		};
>  	};