linux-kernel - Re: [PATCH] perf pmu: Fix resource leaks in pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fV9TVxHx1xveQgUbZnyrDNUmkW=c3OX+DEErfZb_3G_ow@mail.gmail.com>
Date:   Wed, 12 Apr 2023 20:03:58 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Hao Zeng <zenghao@...inos.cn>
Cc:     linux-perf-users@...r.kernel.org, peterz@...radead.org,
        mingo@...hat.com, acme@...nel.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        namhyung@...nel.org, adrian.hunter@...el.com, james.clark@....com,
        suzuki.poulose@....com, ravi.bangoria@....com, seanjc@...gle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf pmu: Fix resource leaks in pmu_cpumask()

On Wed, Apr 12, 2023 at 7:41 PM Hao Zeng <zenghao@...inos.cn> wrote:
>
> The perf_pmu__open_file() and perf_cpu_map__read()
> are called to process the file,but the file is not closed,
> which may cause a file handle leak.
>
> Signed-off-by: Hao Zeng <zenghao@...inos.cn>

Thanks, this was already fixed by Namhyung in:
https://lore.kernel.org/all/20230331202949.810326-9-namhyung@kernel.org/
You may want to check for issues like this in Arnaldo's perf-tools-next tree:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=perf-tools-next
These are the changes planned for Linux 6.4.

Thanks,
Ian

> ---
>  tools/perf/util/pmu.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index c256b29defad..3b4d2f531d83 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -583,6 +583,7 @@ static struct perf_cpu_map *pmu_cpumask(const char *name)
>                 if (!file)
>                         continue;
>                 cpus = perf_cpu_map__read(file);
> +               fclose(file);
>                 if (cpus)
>                         return cpus;
>         }
> --
> 2.37.2
>
>
> No virus found
>                 Checked by Hillstone Network AntiVirus