linux-kernel - RE: [PATCH] misc: mchp_pci1xxxx: mchp_pci1xxxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN8PR11MB3668BB25DB6028404F423086E9989@BN8PR11MB3668.namprd11.prod.outlook.com>
Date:   Thu, 13 Apr 2023 04:43:10 +0000
From:   <Kumaravel.Thiagarajan@...rochip.com>
To:     <Y_Ashley@....com>, <arnd@...db.de>, <gregkh@...uxfoundation.org>
CC:     <dzm91@...t.edu.cn>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] misc: mchp_pci1xxxx: mchp_pci1xxxx_gp: add unwind goto

> -----Original Message-----
> From: Xinyi Hou <Y_Ashley@....com>
> Sent: Sunday, April 9, 2023 6:18 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@...rochip.com>; Arnd Bergmann
> <arnd@...db.de>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Smatch reported:
> 
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:73 gp_aux_bus_probe()
> warn:
> missing unwind goto?
> 
> In gp_aux_bus_probe(), when the allocation of aux_bus-
> >aux_device_wrapper[1] fails, it needs to clean up the allocated resources.
> 
> Fix this by revising the return statement to a goto statement.
> 
> Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver for
> the PIO function in the multi-function endpoint of pci1xxxx device.")
> Signed-off-by: Xinyi Hou <Y_Ashley@....com>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
Reviewed-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>
> ---
> The issue is found by static analysis, and the patch remains untest.
> ---
> 
>  drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> index 32af2b14ff34..2c64b6b3cd9c 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> @@ -69,8 +69,10 @@ static int gp_aux_bus_probe(struct pci_dev *pdev,
> const struct pci_device_id *id
> 
>         aux_bus->aux_device_wrapper[1] = kzalloc(sizeof(*aux_bus-
> >aux_device_wrapper[1]),
>                                                  GFP_KERNEL);
> -       if (!aux_bus->aux_device_wrapper[1])
> -               return -ENOMEM;
> +       if (!aux_bus->aux_device_wrapper[1]) {
> +               retval = -ENOMEM;
> +               goto err_aux_dev_add_0;
> +       }
> 
>         retval = ida_alloc(&gp_client_ida, GFP_KERNEL);
>         if (retval < 0)
> --
> 2.25.1