linux-kernel - Re: [PATCH 2/2] mm: ksm: Support hwpoison for ksm page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230413091355.GA2458769@hori.linux.bs1.fc.nec.co.jp>
Date:   Thu, 13 Apr 2023 09:13:56 +0000
From:   HORIGUCHI NAOYA(堀口　直也) 
        <naoya.horiguchi@....com>
To:     xialonglong <xialonglong1@...wei.com>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linmiaohe@...wei.com" <linmiaohe@...wei.com>,
        "wangkefeng.wang@...wei.com" <wangkefeng.wang@...wei.com>,
        "sunnanyong@...wei.com" <sunnanyong@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH 2/2] mm: ksm: Support hwpoison for ksm page

On Thu, Apr 13, 2023 at 04:00:11PM +0800, xialonglong wrote:
> 
> 
> 在 2023/3/31 13:42, HORIGUCHI NAOYA(堀口 直也) 写道:
> > On Thu, Mar 30, 2023 at 03:45:01PM +0800, Longlong Xia wrote:
> > > hwpoison_user_mappings() is updated to support ksm pages, and add
> > > collect_procs_ksm() to collect processes when the error hit an ksm
> > > page. The difference from collect_procs_anon() is that it also needs
> > > to traverse the rmap-item list on the stable node of the ksm page.
> > > At the same time, add_to_kill_ksm() is added to handle ksm pages. And
> > > task_in_to_kill_list() is added to avoid duplicate addition of tsk to
> > > the to_kill list. This is because when scanning the list, if the pages
> > > that make up the ksm page all come from the same process, they may be
> > > added repeatedly.
> > > 
> > > Signed-off-by: Longlong Xia <xialonglong1@...wei.com>
> > 
> > I don't find any specific issue by code review for now, so I'll try to
> > test your patches.
> 
> Dear maintainer,
> 
> Can you please provide a brief update on the testing status of the patch and
> any suggestions you may have for improving it?

Sorry for my late response, my ksm-related testcases get to pass with your
patches. So feel free to add my tested-by.
Tested-by: Naoya Horiguchi <naoya.horiguchi@....com>