linux-kernel - Re: [PATCH 1/3] objtool: Separate prefix code from stack validation code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Apr 2023 11:30:31 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...nel.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Miroslav Benes <mbenes@...e.cz>
Subject: Re: [PATCH 1/3] objtool: Separate prefix code from stack validation
 code

On Wed, Apr 12, 2023 at 01:26:13PM -0700, Josh Poimboeuf wrote:
> Simplify the prefix code and make it a standalone feature.

The main thing being that you moved it all after
validate_reachable_instructions() ?


> +static int add_prefix_symbols(struct objtool_file *file)
> +{
> +	struct section *sec;
> +	struct symbol *func;
> +	int ret, warnings = 0;
> +
> +	for_each_sec(file, sec) {
> +		if (!(sec->sh.sh_flags & SHF_EXECINSTR))
> +			continue;
> +
> +		list_for_each_entry(func, &sec->symbol_list, list) {

One of the other patches did a sec_for_each_symbol() thing.

> +			if (func->type != STT_FUNC)
> +				continue;
> +
> +			add_prefix_symbol(file, func);
> +		}
> +	}
> +
> +	return warnings;
> +}