linux-kernel - Re: Possible incorrect handling of fault injection inside KMSAN instrumentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG_fn=WOZ2RTyTYrgV3JhsqESf-YCmj_FmbzJZdJogpZk8SnOw@mail.gmail.com>
Date:   Thu, 13 Apr 2023 11:42:01 +0200
From:   Alexander Potapenko <glider@...gle.com>
To:     Dipanjan Das <mail.dipanjan.das@...il.com>
Cc:     Marco Elver <elver@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        kasan-dev@...glegroups.com, linux-mm@...ck.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        syzkaller <syzkaller@...glegroups.com>,
        Marius Fleischer <fleischermarius@...glemail.com>,
        Priyanka Bose <its.priyanka.bose@...il.com>
Subject: Re: Possible incorrect handling of fault injection inside KMSAN instrumentation

On Wed, Apr 12, 2023 at 8:24 PM Dipanjan Das
<mail.dipanjan.das@...il.com> wrote:
>
> On Wed, Apr 12, 2023 at 7:39 AM Alexander Potapenko <glider@...gle.com> wrote:
>
> > Here are two patches that fix the problem:
> >  - https://github.com/google/kmsan/commit/b793a6d5a1c1258326b0f53d6e3ac8aa3eeb3499
> > - for kmsan_vmap_pages_range_noflush();
> >  - https://github.com/google/kmsan/commit/cb9e33e0cd7ff735bc302ff69c02274f24060cff
> > - for kmsan_ioremap_page_range()
> >
> > Can you please try them out?
>
> The second patch needs a small modification.
>
> The return value of `__vmap_pages_range_noflush` at Line 181
> (https://github.com/google/kmsan/commit/cb9e33e0cd7ff735bc302ff69c02274f24060cff#diff-6c23520766ef70571c16b74ed93474716645c7ba81dc07028c076b6fd5ad2731R181)
> should also be assigned to `mapped`. With this modification, the patch
> works.

Good catch, thanks!
I'll send an updated version.