linux-kernel - Re: [PATCH v4] iommu/rockchip: Add missing set_platform_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZDfQkmiPaNalNx2W@8bytes.org>
Date:   Thu, 13 Apr 2023 11:51:14 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     Steven Price <steven.price@....com>
Cc:     Heiko Stuebner <heiko@...ech.de>, Jason Gunthorpe <jgg@...pe.ca>,
        Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>, iommu@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        John Keeping <john@...anate.com>
Subject: Re: [PATCH v4] iommu/rockchip: Add missing set_platform_dma_ops
 callback

On Fri, Mar 31, 2023 at 10:51:54AM +0100, Steven Price wrote:
> Similar to exynos, we need a set_platform_dma_ops() callback for proper
> operation on ARM 32 bit after recent changes in the IOMMU framework
> (detach ops removal). But also the use of a NULL domain is confusing.
> 
> Rework the code to add support for IOMMU_DOMAIN_IDENTITY and a singleton
> rk_identity_domain which is assigned to domain when using an identity
> mapping rather than "detaching". This makes the code easier to reason about.
> 
> Signed-off-by: Steven Price <steven.price@....com>
> ---
> Changes since v3[1]:
> 
>  * Added a dummy free callback to rk_identity_ops.
> 
> [1] https://lore.kernel.org/r/20230330144604.2431436-1-steven.price%40arm.com
> 
>  drivers/iommu/rockchip-iommu.c | 61 ++++++++++++++++++++++++++--------
>  1 file changed, 47 insertions(+), 14 deletions(-)

Applied, thanks.