[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <66b5cf7-391-8d63-b7da-267fe8a639bd@linux.intel.com>
Date: Thu, 13 Apr 2023 13:17:18 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "David E. Box" <david.e.box@...ux.intel.com>
cc: hdegoede@...hat.com, markgross@...nel.org,
platform-driver-x86@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86/intel/sdsi: Change mailbox timeout
On Wed, 12 Apr 2023, David E. Box wrote:
> On some platforms, it may take up to 400ms for the ready bit to be set in a
> successful mailbox transaction. Set the timeout to 500ms to cover the worst
> case.
>
> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> ---
> drivers/platform/x86/intel/sdsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
> index 9e0ea2cdd704..556e7c6dbb05 100644
> --- a/drivers/platform/x86/intel/sdsi.c
> +++ b/drivers/platform/x86/intel/sdsi.c
> @@ -49,7 +49,7 @@
> #define SDSI_MBOX_CMD_SUCCESS 0x40
> #define SDSI_MBOX_CMD_TIMEOUT 0x80
>
> -#define MBOX_TIMEOUT_US 2000
> +#define MBOX_TIMEOUT_US 500000
> #define MBOX_TIMEOUT_ACQUIRE_US 1000
> #define MBOX_POLLING_PERIOD_US 100
> #define MBOX_ACQUIRE_NUM_RETRIES 5
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
--
i.
Powered by blists - more mailing lists