linux-kernel - Re: [PATCH v2 6/7] leds: leds-mt6323: Add support for MT6331 leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Apr 2023 13:01:10 +0200
From:   Pavel Machek <pavel@....cz>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     lee@...nel.org, sean.wang@...iatek.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH v2 6/7] leds: leds-mt6323: Add support for MT6331 leds

Hi!

> Add the register offsets for MT6331. The hwspec is the same as MT6323.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  drivers/leds/leds-mt6323.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c
> index 182256ec1924..5d95dbd9a761 100644
> --- a/drivers/leds/leds-mt6323.c
> +++ b/drivers/leds/leds-mt6323.c
> @@ -531,6 +531,17 @@ static const struct mt6323_regs mt6323_registers = {
>  	.isink_en_ctrl = 0x356,
>  };
>  
> +static const struct mt6323_regs mt6331_registers = {
> +	.top_ckpdn = (const u16[]){ 0x138, 0x13e, 0x144 },
> +	.num_top_ckpdn = 3,
> +	.top_ckcon = (const u16[]){ 0x14c, 0x14a },
> +	.num_top_ckcon = 2,
> +	.isink_con = (const u16[]){ 0x40c, 0x40e, 0x410, 0x412, 0x414 },
> +	.num_isink_con = 5,
> +	.isink_max_regs = 4, /* ISINK[0..3] */
> +	.isink_en_ctrl = 0x43a,
> +};
> +
>  static const struct mt6323_hwspec mt6323_spec = {
>  	.max_period = 10000,
>  	.max_leds = 4,
> @@ -543,8 +554,14 @@ static const struct mt6323_data mt6323_pdata = {
>  	.spec = &mt6323_spec,
>  };
>  
> +static const struct mt6323_data mt6331_pdata = {
> +	.regs = &mt6331_registers,
> +	.spec = &mt6323_spec,
> +};
> +
>  static const struct of_device_id mt6323_led_dt_match[] = {
>  	{ .compatible = "mediatek,mt6323-led", .data = &mt6323_pdata},
> +	{ .compatible = "mediatek,mt6331-led", .data = &mt6331_pdata },
>  	{},

" " before } is missing.

But that's really detail.

Acked-by: Pavel Machek <pavel@....cz>
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)