linux-kernel - RE: [RESEND PATCH] usb: renesas_usbhs: Fix use after free bug in usbhs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYBPR01MB5341FED435E5533E4B60B10CD8989@TYBPR01MB5341.jpnprd01.prod.outlook.com>
Date:   Thu, 13 Apr 2023 12:19:44 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Zheng Wang <zyytlz.wz@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hackerzheng666@...il.com" <hackerzheng666@...il.com>,
        "1395428693sheep@...il.com" <1395428693sheep@...il.com>,
        "alex000young@...il.com" <alex000young@...il.com>
Subject: RE: [RESEND PATCH] usb: renesas_usbhs: Fix use after free bug in
 usbhs_remove due to race condition

Hi,

> From: Zheng Wang, Sent: Thursday, April 13, 2023 4:49 PM
> 
> In usbhs_probe, &priv->notify_hotplug_work is bound with
> usbhsc_notify_hotplug. It will be started then.
> 
> If we remove the driver which will call usbhs_remove
>   to make cleanup, there may be a unfinished work.
> 
> The possible sequence is as follows:
> 
> Fix it by finishing the work before cleanup in the usbhs_remove
> 
> CPU0                  CPU1
> 
>                     |usbhsc_notify_hotplug
> usbhs_remove         |
> usbhs_mod_remove     |
> usbhs_mod_gadget_remove|
> kfree(gpriv);       |
>                     |usbhsc_hotplug
>                     |usbhs_mod_call start
>                     |usbhsg_start
>                     |usbhsg_try_start
>                     |//use gpriv

Thank you for the patch!

You should adjust the figure like followings because Greg mentioned it on other patch [1].
-----
CPU0                      CPU1

                        | usbhsc_notify_hotplug
usbhs_remove            |
usbhs_mod_remove        |
usbhs_mod_gadget_remove |
kfree(gpriv);           |
                        | usbhsc_hotplug
                        | usbhs_mod_call start
                        | usbhsg_start
                        | usbhsg_try_start
                        | //use gpriv
-----

[1]
https://lore.kernel.org/lkml/ZBNCam0XjWehrF3c@kroah.com/

Best regards,
Yoshihiro Shimoda

> Fixes: bc57381e6347 ("usb: renesas_usbhs: use delayed_work instead of work_struct")
> Signed-off-by: Zheng Wang <zyytlz.wz@....com>
> ---
>  drivers/usb/renesas_usbhs/common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
> index 96f3939a65e2..17a0987ef4f5 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -768,6 +768,7 @@ static int usbhs_remove(struct platform_device *pdev)
> 
>  	dev_dbg(&pdev->dev, "usb remove\n");
> 
> +	cancel_delayed_work_sync(&priv->notify_hotplug_work);
>  	/* power off */
>  	if (!usbhs_get_dparam(priv, runtime_pwctrl))
>  		usbhsc_power_ctrl(priv, 0);
> --
> 2.25.1