linux-kernel - Re: [PATCH] drm/stm: ltdc: fix late dereference check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <31659e74-661b-8bd3-e64e-33ac6d24f577@foss.st.com>
Date:   Thu, 13 Apr 2023 15:04:37 +0200
From:   Yannick FERTRE <yannick.fertre@...s.st.com>
To:     Raphael GALLAIS-POU <gallais1@....st.com>,
        Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>,
        Philippe Cornu <philippe.cornu@...s.st.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>
CC:     <dri-devel@...ts.freedesktop.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>,
        Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] drm/stm: ltdc: fix late dereference check

Hi Raphael,

thanks for the patch.

Reviewed-by: Yannick Fertre <yannick.fertre@...s.st.com>


On 4/12/23 11:25, Raphael GALLAIS-POU wrote:
> Attention: Sender not authenticated
> --------------------------------------------------
>
> In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a
> container_of() before the pointer check. This could cause a kernel panic.
>
> Fix this smatch warning:
> drivers/gpu/drm/stm/ltdc.c:1124 ltdc_crtc_set_crc_source() warn: variable dereferenced before check 'crtc' (see line 1119)
>
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <error27@...il.com>
> Link: https://lore.kernel.org/lkml/202212241802.zeLFZCXB-lkp@intel.com/
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
> ---
>   drivers/gpu/drm/stm/ltdc.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 03c6becda795..b8be4c1db423 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1145,7 +1145,7 @@ static void ltdc_crtc_disable_vblank(struct drm_crtc *crtc)
>
>   static int ltdc_crtc_set_crc_source(struct drm_crtc *crtc, const char *source)
>   {
> -       struct ltdc_device *ldev = crtc_to_ltdc(crtc);
> +       struct ltdc_device *ldev;
>          int ret;
>
>          DRM_DEBUG_DRIVER("\n");
> @@ -1153,6 +1153,8 @@ static int ltdc_crtc_set_crc_source(struct drm_crtc *crtc, const char *source)
>          if (!crtc)
>                  return -ENODEV;
>
> +       ldev = crtc_to_ltdc(crtc);
> +
>          if (source && strcmp(source, "auto") == 0) {
>                  ldev->crc_active = true;
>                  ret = regmap_set_bits(ldev->regmap, LTDC_GCR, GCR_CRCEN);
> --
> 2.25.1
>