linux-kernel - Re: [PATCH 5/5] drm/panel: nt36523: Add Lenovo J606F panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDdmQS/9diY7PJ4A@Gentoo>
Date:   Thu, 13 Apr 2023 10:17:37 +0800
From:   Jianhua Lu <lujianhua000@...il.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     Neil Armstrong <neil.armstrong@...aro.org>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] drm/panel: nt36523: Add Lenovo J606F panel

On Wed, Apr 12, 2023 at 09:46:02PM +0200, Konrad Dybcio wrote:
> Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3
> video mode display. Add support for these panels.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>  drivers/gpu/drm/panel/panel-novatek-nt36523.c | 491 ++++++++++++++++++++++++++
>  1 file changed, 491 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> index db4b4af13ec1..4bf9f8db26ba 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> @@ -13,6 +13,8 @@
>  #include <linux/of_graph.h>
>  #include <linux/regulator/consumer.h>
>  
[..] 
> +static const struct panel_desc j606f_boe_desc = {
> +	.modes = j606f_boe_modes,
> +	.num_modes = ARRAY_SIZE(j606f_boe_modes),
> +	.dsi_info = {
> +		.type = "J606F BOE",
> +		.channel = 0,
> +		.node = NULL,
> +	},
The dsi_info just be used to register slave dsi, for single dsi case, can drop
it.

Otherwise looks great, thanks!

Reviewed-by: Jianhua Lu <lujianhua000@...il.com>
> +	.width_mm = 143,
> +	.height_mm = 235,
> +	.bpc = 8,
> +	.lanes = 4,
> +	.format = MIPI_DSI_FMT_RGB888,
> +	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> +		      MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
> +	.init_sequence = j606f_boe_init_sequence,
> +	.has_dcs_backlight = true,
> +};
> +
>  static void nt36523_reset(struct panel_info *pinfo)
>  {
>  	gpiod_set_value_cansleep(pinfo->reset_gpio, 1);
> @@ -826,6 +1313,10 @@ static int nt36523_probe(struct mipi_dsi_device *dsi)
>  }
>  
>  static const struct of_device_id nt36523_of_match[] = {
> +	{
> +		.compatible = "lenovo,j606f-boe-nt36523w",
> +		.data = &j606f_boe_desc,
> +	},
>  	{
>  		.compatible = "xiaomi,elish-boe-nt36523",
>  		.data = &elish_boe_desc,
> 
> -- 
> 2.40.0
>