linux-kernel - Re: [PATCH v2 5/9] objtool: Add verbose option for disassembling affected functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230413150516.obilsce2akxihri6@treble>
Date:   Thu, 13 Apr 2023 08:05:16 -0700
From:   Josh Poimboeuf <jpoimboe@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Miroslav Benes <mbenes@...e.cz>
Subject: Re: [PATCH v2 5/9] objtool: Add verbose option for disassembling
 affected functions

On Thu, Apr 13, 2023 at 10:05:27AM +0200, Peter Zijlstra wrote:
> > @@ -118,6 +119,10 @@ int cmd_parse_options(int argc, const char **argv, const char * const usage[])
> >  		parse_options(envc, envv, check_options, env_usage, 0);
> >  	}
> >  
> > +	env = getenv("OBJTOOL_VERBOSE");
> > +	if (env && !strcmp(env, "1"))
> > +		opts.verbose = true;
> > +
> >  	argc = parse_options(argc, argv, check_options, usage, 0);
> >  	if (argc != 1)
> >  		usage_with_options(usage, check_options);
> 
> No real objection; but I do feel obliged to point out that:
> OBJTOOL_ARGS="-v" achieves much the same.

But OBJTOOL_VERBOSE=1 just rolls off the fingers :-)

-- 
Josh