linux-kernel - Re: [PATCH] Binder: Add timestamp and async from pid/tid to transaction record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2023041324-molecule-clad-b580@gregkh>
Date:   Thu, 13 Apr 2023 17:06:01 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chuang Zhang <zhangchuang3@...omi.corp-partner.google.com>
Cc:     arve@...roid.com, tkjos@...roid.com, maco@...roid.com,
        joel@...lfernandes.org, brauner@...nel.org, cmllamas@...gle.com,
        surenb@...gle.com, linux-kernel@...r.kernel.org,
        Chuang Zhang <zhangchuang3@...omi.com>
Subject: Re: [PATCH] Binder: Add timestamp and async from pid/tid to
 transaction record

On Thu, Apr 13, 2023 at 09:03:08PM +0800, Chuang Zhang wrote:
> On Thu, Apr 13, 2023 at 8:36 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> > On Thu, Apr 13, 2023 at 08:34:06PM +0800, Chuang Zhang wrote:
> > > On Thu, Apr 13, 2023 at 8:17 PM Greg KH <gregkh@...uxfoundation.org>
> > wrote:
> > > > And how are pid namespaces being handled here?  I know it's just
> > > > debugging data but showing a pid from the wrong namespace probably
> > would
> > > > not be a good idea as it might get confusing quickly.
> > > >
> > > [chuang] Do you have any good suggestions? thanks
> >
> > I do not know what you are using this debug information for, nor how or
> > if Android uses pid namespaces (I think it does?)
> >
> [chuang]
> So can I use (struct binder_thread *async_from) instead ?
> and get the corresponding pid and tid through the following way:
> async_from->proc->pid
> async_from->pid

I don't know, try it and see!

I'm not quite sure what debugging information you can get here with the
pid, nor what you intend to do with it, so I can't answer this very
well, sorry.

thanks,

greg k-h