linux-kernel - Re: [PATCH 1/2] serial: 8250_exar: Use PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDmIXoARLYXb8k9z@smile.fi.intel.com>
Date:   Fri, 14 Apr 2023 20:07:42 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Andrew Davis <afd@...com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] serial: 8250_exar: Use PCI_DEVICE_DATA macro directly

On Thu, Apr 13, 2023 at 04:44:20PM -0500, Andrew Davis wrote:
> The EXAR_DEVICE macro was converted to use PCI_DEVICE_DATA, having
> this macro at doesn't add much, remove it.

I'm not against this, but I have to point out that this patch brings
inconsistency into the table. Either convert all, or none, I think.

That's why the patch that converts EXAR_DEVICE() to use PCI_DEVICE_DATA()
had a little intrusion.


-- 
With Best Regards,
Andy Shevchenko