linux-kernel - Re: [PATCH] selftests/resctrl: Fix incorrect error return on test complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed27df52-969c-3d07-7c1d-2dc1566cc850@linuxfoundation.org>
Date:   Fri, 14 Apr 2023 11:16:15 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Reinette Chatre <reinette.chatre@...el.com>, shuah@...nel.org
Cc:     ilpo.jarvinen@...ux.intel.com, tan.shaopeng@...fujitsu.com,
        fenghua.yu@...el.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/resctrl: Fix incorrect error return on test
 complete

On 4/14/23 10:43, Reinette Chatre wrote:
> An error snuck in between two recent conflicting changes:
> Until recently ->setup() used negative values to indicate
> normal test termination. This was changed in
> commit fa10366cc6f4 ("selftests/resctrl: Allow ->setup() to return
> errors") that transitioned ->setup() to use negative values
> to indicate errors and a new END_OF_TESTS to indicate normal
> termination.
> 
> commit 42e3b093eb7c ("selftests/resctrl: Fix set up schemata with 100%
> allocation on first run in MBM test") continued to use
> negative return to indicate normal test termination.
> 
> Fix mbm_setup() to use the new END_OF_TESTS to indicate
> error-free test termination.
> 
> Fixes: 42e3b093eb7c ("selftests/resctrl: Fix set up schemata with 100% allocation on first run in MBM test")
> Reported-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> Link: https://lore.kernel.org/lkml/bb65cce8-54d7-68c5-ef19-3364ec95392a@linux.intel.com/
> Signed-off-by: Reinette Chatre <reinette.chatre@...el.com>
> ---
> Hi Shuah,
> 
> Apologies, this error snuck in between the two series
> merged into kselftest's next this week.
> 

No worries. This is now applied on top of others to linux-kselftest
net.

thanks,
-- Shuah