lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 13 Apr 2023 22:50:07 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Kelvin.Cao@...rochip.com
Cc:     hch@...radead.org, dmaengine@...r.kernel.org, vkoul@...nel.org,
        George.Ge@...rochip.com, linux-kernel@...r.kernel.org,
        logang@...tatee.com
Subject: Re: [PATCH v2 1/1] dmaengine: switchtec-dma: Introduce Switchtec DMA
 engine PCI driver

On Thu, Apr 13, 2023 at 10:40:41PM +0000, Kelvin.Cao@...rochip.com wrote:
> > > Why is the lock needed while reading the status and waiting
> > > for it with long delays?
> There's (low) chance of access to the same ctrl register from other
> paths which might change the value of status in an unexpected way. It
> also prevents the hardware operation from being interrupted until it
> indicates it has finished by a bit set in the status register.

Well, the lock is obviously required to protecte the reads to the
register.  But why do you need to hold the lock over the reads and
the delay?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ