linux-kernel - Re: [PATCHv4 1/3] dt-bindings: usb: Add RK3588 OHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9ceba633-cf36-efd3-6889-1bbe6755b398@linaro.org>
Date:   Fri, 14 Apr 2023 09:34:34 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCHv4 1/3] dt-bindings: usb: Add RK3588 OHCI

On 13/04/2023 19:31, Sebastian Reichel wrote:
> Add compatible for RK3588 OHCI. As far as I know it's fully
> compatible with generic-ohci.
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Sebastian,

Can you fix PATCH subject part in all your submissions? There should be
a space between PATCH and v. Just like `git format-patch` creates. If
you use other tools for this, fix them so they don't create other format.

You also need to rebase your patches - this is something old and cannot
be applied.

> ---
>  .../devicetree/bindings/usb/generic-ohci.yaml    | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index a9ba7257b884..4feb993af53b 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -44,6 +44,7 @@ properties:
>                - hpe,gxp-ohci
>                - ibm,476gtr-ohci
>                - ingenic,jz4740-ohci
> +              - rockchip,rk3588-ohci
>                - snps,hsdk-v1.0-ohci
>            - const: generic-ohci
>        - enum:
> @@ -69,7 +70,7 @@ properties:
>  
>    clocks:
>      minItems: 1
> -    maxItems: 3
> +    maxItems: 4
>      description: |
>        In case the Renesas R-Car Gen3 SoCs:
>          - if a host only channel: first clock should be host.
> @@ -147,6 +148,19 @@ allOf:
>      then:
>        properties:
>          transceiver: false
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3588-ohci
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 4
> +    else:
> +      properties:
> +        clocks:

Please test the patches before sending. If you tested, you would see
warnings here.

You need minItems: 1.

> +          maxItems: 3
>  
>  additionalProperties: false
>  

Best regards,
Krzysztof