linux-kernel - Re: [PATCH v11 1/8] function_graph: Support recording and printing the return value of function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7eabae11-6a65-c51d-ff39-8205057e497a@sangfor.com.cn>
Date:   Fri, 14 Apr 2023 15:55:05 +0800
From:   Donglin Peng <pengdonglin@...gfor.com.cn>
To:     mhiramat@...nel.org, rostedt@...dmis.org
Cc:     huangcun@...gfor.com.cn, dinghui@...gfor.com.cn,
        catalin.marinas@....com, mark.rutland@....com,
        paul.walmsley@...ive.com, palmer@...belt.com, bp@...en8.de,
        tglx@...utronix.de, aou@...s.berkeley.edu,
        rmk+kernel@...linux.org.uk, linux@...linux.org.uk, will@...nel.org,
        peterz@...radead.org, mingo@...hat.com, zhangqing@...ngson.cn,
        chenhuacai@...nel.org, kernel@...0n.name, dolinux.peng@...il.com,
        x86@...nel.org, linux-trace-kernel@...r.kernel.org,
        loongarch@...ts.linux.dev, linux-riscv@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Florian Kauer <florian.kauer@...utronix.de>,
        dave.hansen@...ux.intel.com, hpa@...or.com, xiehuan09@...il.com
Subject: Re: [PATCH v11 1/8] function_graph: Support recording and printing
 the return value of function

On 2023/4/14 15:44, Donglin Peng wrote:
> On 2023/4/8 20:42, Donglin Peng wrote:
>> Analyzing system call failures with the function_graph tracer can be a
>> time-consuming process, particularly when locating the kernel function
>> that first returns an error in the trace logs. This change aims to
>> simplify the process by recording the function return value to the
>> 'retval' member of 'ftrace_graph_ent' and printing it when outputting
> 
> There is a mistake, the retval member is added to ftrace_graph_ret.

Hi Steve, could you please correct this mistake before merging it into
linux-next?

> 
>> the trace log.
>>