linux-kernel - Re: [PATCH RESEND v2] firmware/psci: demote suspend-mode warning to info level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJppa6OUqaiN61mDr_xSEsAqJtLHGvwuwBDcWYaeLEwkVYQ@mail.gmail.com>
Date:   Fri, 14 Apr 2023 12:36:48 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Johan Hovold <johan+linaro@...nel.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v2] firmware/psci: demote suspend-mode warning to
 info level

On Fri, 14 Apr 2023 at 11:47, Johan Hovold <johan+linaro@...nel.org> wrote:
>
> On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode
> during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb
> ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this
> is now logged at warning level:
>
>         psci: failed to set PC mode: -3
>
> As there is nothing users can do about the firmware behaving this way,
> demote the warning to info level and clearly mark it as a firmware bug:
>
>         psci: [Firmware Bug]: failed to set PC mode: -3
>
> Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>
> Acked-by: Mark Rutland <mark.rutland@....com>
> Acked-by: Sudeep Holla <sudeep.holla@....com>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---

For the sake of completeness:
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

>
> This one fell between the cracks so resending with tags added.
>
> Mark or Lorenzo, is this something you can pick up?
>
> Johan
>


-- 
With best wishes
Dmitry