linux-kernel - Re: [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Apr 2023 11:39:17 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     ReaperLi <ReaperLi@...nfly.com>
Cc:     <perex@...ex.cz>, <tiwai@...e.com>, <linux-kernel@...r.kernel.org>,
        jasontao <jasontao@...nfly.com>
Subject: Re: [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs.

On Fri, 14 Apr 2023 10:50:55 +0200,
ReaperLi wrote:
> 
> From: jasontao <jasontao@...nfly.com>
> 
> Add a set of HD Audio PCI IDS, and the HDMI codec vendor IDs for
> Glenfly Arise.
> 
> Signed-off-by: jasontao <jasontao@...nfly.com>

Your Signed-off-by tag seems missing.  The person who submitted the
patch must give the own Signed-off-by tag.  That's a legal
requirement.

Moreover, the patch doesn't seem applicable with git-am.  Please fix
your mailer setup to stop mangling tabs with spaces.
At best, use git-send-email for submission.

If anything else can't work, use a mail attachment as a last resort.

The code change itself looks good to me.  Please resubmit for the
above points.

thanks,

Takashi