linux-kernel - Re: [PATCH] Input: vmmouse - add macros to enable vmmouse relative mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36d0b466c96b42f5fd364c2a80379d6d7be9cb48.camel@vmware.com>
Date:   Fri, 14 Apr 2023 01:22:25 +0000
From:   Zack Rusin <zackr@...are.com>
To:     "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        Pv-drivers <Pv-drivers@...are.com>,
        "zhouzongmin@...inos.cn" <zhouzongmin@...inos.cn>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@...are.com>
CC:     "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: vmmouse - add macros to enable vmmouse relative
 mode

On Thu, 2023-04-13 at 16:56 +0800, Zongmin Zhou wrote:
> Add macros to enable request relative mode.
> 
> Change the REL_Y value passed by input_report_rel function,
> to match the direction of mouse movement.

Thanks for the patch, but in its current form it's a nack. First of all we don't
want any defines in the driver code that affect compilation, it's never going to be
tested or compiled in. Either a kconfig or a module parameter would be acceptable
but that's only if you can actually explain what it is that you're fixing. The
current single line description just mentions what the effect it has (not completely
correctly either because for merged packets absolute will still be x=x, y=y, but
relative will be x += dx, y -= dy) but not why it's done, what it's fixing and how
to reproduce.

z