linux-kernel - Re: [PATCH 5/5] dnotify: Pass argument of fcntl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230414-vorgibt-kringeln-f8bf1ae5278e@brauner>
Date:   Fri, 14 Apr 2023 14:34:22 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Jan Kara <jack@...e.cz>
Cc:     Luca Vizzarro <Luca.Vizzarro@....com>,
        linux-kernel@...r.kernel.org,
        Kevin Brodsky <Kevin.Brodsky@....com>,
        Szabolcs Nagy <Szabolcs.Nagy@....com>,
        Theodore Ts'o <tytso@....edu>,
        David Laight <David.Laight@...LAB.com>,
        Mark Rutland <Mark.Rutland@....com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Jeff Layton <jlayton@...nel.org>,
        Chuck Lever <chuck.lever@...cle.com>,
        linux-fsdevel@...r.kernel.org, Amir Goldstein <amir73il@...il.com>
Subject: Re: [PATCH 5/5] dnotify: Pass argument of fcntl_dirnotify as int

On Fri, Apr 14, 2023 at 12:46:25PM +0200, Jan Kara wrote:
> On Fri 14-04-23 11:02:12, Luca Vizzarro wrote:
> > The interface for fcntl expects the argument passed for the command
> > F_DIRNOTIFY to be of type int. The current code wrongly treats it as
> > a long. In order to avoid access to undefined bits, we should explicitly
> > cast the argument to int.
> > 
> > Cc: Kevin Brodsky <Kevin.Brodsky@....com>
> > Cc: Szabolcs Nagy <Szabolcs.Nagy@....com>
> > Cc: "Theodore Ts'o" <tytso@....edu>
> > Cc: David Laight <David.Laight@...LAB.com>
> > Cc: Mark Rutland <Mark.Rutland@....com>
> > Cc: Alexander Viro <viro@...iv.linux.org.uk>
> > Cc: Christian Brauner <brauner@...nel.org>
> > Cc: Jeff Layton <jlayton@...nel.org>
> > Cc: Chuck Lever <chuck.lever@...cle.com>
> > Cc: linux-fsdevel@...r.kernel.org
> > Cc: Jan Kara <jack@...e.cz>
> > Cc: Amir Goldstein <amir73il@...il.com>
> > Signed-off-by: Luca Vizzarro <Luca.Vizzarro@....com>
> 
> Looks good to me. Do you plan to merge this series together (perhaps
> Christian could?) or should I pick up the dnotify patch? In case someone
> else will merge the patch feel free to add:
> 
> Acked-by: Jan Kara <jack@...e.cz>

Yeah, I'm happy to carry it once it's reviewed if noone objects.