linux-kernel - Re: [PATCH] serial: 8250: Add missing wakeup event reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd092a59-dc44-2c26-5c72-c9b442cf2bc8@gmail.com>
Date:   Fri, 14 Apr 2023 05:54:06 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:     linux-kernel@...r.kernel.org, opendmb@...il.com,
        bcm-kernel-feedback-list@...adcom.com,
        Jiri Slaby <jirislaby@...nel.org>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        "Maciej W. Rozycki" <macro@...am.me.uk>,
        Eric Tremblay <etremblay@...tech-controls.com>,
        Wander Lairson Costa <wander@...hat.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250: Add missing wakeup event reporting



On 4/14/2023 12:19 AM, Greg Kroah-Hartman wrote:
> On Thu, Apr 13, 2023 at 02:39:54PM -0700, Florian Fainelli wrote:
>> An 8250 UART configured as a wake-up source would not have reported
>> itself through sysfs as being the source of wake-up, correct that.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>> ---
>>   drivers/tty/serial/8250/8250_port.c | 4 ++++
>>   1 file changed, 4 insertions(+)
> 
> What commit does this fix?  Is it needed to go to stable kernel(s)?

That would be b3b708fa2780cd2b5d8266a8f0c3a1cab364d4d2 ("wake up from a 
serial port").

I do not know of standard Linux distribution user-space relying on the 
wake-up counts from sysfs, though I certainly do care.

The patch I submitted should backport fine all the way down to 4.14 
where irqd_is_wakeup_set is available. Do you want me to submit a v2 
with that Fixes tag?
-- 
Florian