linux-kernel - Re: [PATCH 8/8] arm64: dts: qcom: sdm632-fairphone-fp3: Add notification LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5205040.31r3eYUQgx@z3ntu.xyz>
Date:   Fri, 14 Apr 2023 17:49:47 +0200
From:   Luca Weiss <luca@...tu.xyz>
To:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 8/8] arm64: dts: qcom: sdm632-fairphone-fp3: Add notification LED

On Freitag, 14. April 2023 01:36:38 CEST Konrad Dybcio wrote:
> On 14.04.2023 01:17, Luca Weiss wrote:
> > The phone features a notification LED connected to the pmi632. Configure
> > the RGB led found on it.
> > 
> > Signed-off-by: Luca Weiss <luca@...tu.xyz>
> > ---
> > 
> >  arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 29
> >  +++++++++++++++++++++++ 1 file changed, 29 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts index
> > 70e683b7e4fc..301eca9a4f31 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > @@ -4,8 +4,10 @@
> > 
> >   */
> >  
> >  /dts-v1/;
> > 
> > +#include <dt-bindings/leds/common.h>
> > 
> >  #include "sdm632.dtsi"
> >  #include "pm8953.dtsi"
> > 
> > +#include "pmi632.dtsi"
> > 
> >  / {
> >  
> >  	model = "Fairphone 3";
> > 
> > @@ -83,6 +85,33 @@ &pm8953_resin {
> > 
> >  	linux,code = <KEY_VOLUMEDOWN>;
> >  
> >  };
> > 
> > +&pmi632_lpg {
> 
> qcom,power-source?

This property is only used if triled_has_src_sel is set in the driver (which 
it isn't on pmi632), only on pm8941 & pmi8994 it is set.

Regards
Luca

> 
> Konrad
> 
> > +	status = "okay";
> > +
> > +	multi-led {
> > +		color = <LED_COLOR_ID_RGB>;
> > +		function = LED_FUNCTION_STATUS;
> > +
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		led@1 {
> > +			reg = <1>;
> > +			color = <LED_COLOR_ID_RED>;
> > +		};
> > +
> > +		led@2 {
> > +			reg = <2>;
> > +			color = <LED_COLOR_ID_GREEN>;
> > +		};
> > +
> > +		led@3 {
> > +			reg = <3>;
> > +			color = <LED_COLOR_ID_BLUE>;
> > +		};
> > +	};
> > +};
> > +
> > 
> >  &sdhc_1 {
> >  
> >  	status = "okay";
> >  	vmmc-supply = <&pm8953_l8>;