linux-kernel - Re: [PATCH] ixp4xx_crypto: fix building wiht 64-bit dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZDl5PkEvkyMM5qF0@gondor.apana.org.au>
Date:   Sat, 15 Apr 2023 00:03:10 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Linus Walleij <linusw@...nel.org>, Imre Kaloz <kaloz@...nwrt.org>,
        Krzysztof Halasa <khalasa@...p.pl>,
        Corentin Labbe <clabbe@...libre.com>,
        "David S. Miller" <davem@...emloft.net>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Arnd Bergmann <arnd@...db.de>, linux-crypto@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ixp4xx_crypto: fix building wiht 64-bit dma_addr_t

On Fri, Apr 14, 2023 at 10:06:56AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The crypt_ctl structure must be exactly 64 bytes long to work correctly,
> and it has to be a power-of-two size to allow turning the
> 64-bit division in crypt_phys2virt() into a shift operation, avoiding
> the link failure:
> 
> ERROR: modpost: "__aeabi_uldivmod" [drivers/crypto/intel/ixp4xx/ixp4xx_crypto.ko] undefined!
> 
> The failure now shows up because the driver is available for compile
> testing after the move, and a previous fix turned the more descriptive
> BUILD_BUG_ON() into a link error.
> 
> Change the variably-sized dma_addr_t into the expected 'u32' type that is
> needed for the hardware, and reinstate the size check for all 32-bit
> architectures to simplify debugging if it hits again.
> 
> Fixes: 1bc7fdbf2677 ("crypto: ixp4xx - Move driver to drivers/crypto/intel/ixp4xx")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/crypto/intel/ixp4xx/ixp4xx_crypto.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt