linux-kernel - Re: [PATCH] ASoC: dt-bindings: wm8753: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 Apr 2023 11:16:29 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Saalim Quadri <danascape@...il.com>, lgirdwood@...il.com,
        broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, daniel.baluta@....com
Cc:     patches@...nsource.cirrus.com, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: wm8753: Convert to dtschema

On 15/04/2023 00:38, Saalim Quadri wrote:
> Convert the WM8753 audio codec bindings to DT schema.
> 
> Signed-off-by: Saalim Quadri <danascape@...il.com>
> ---
>  .../devicetree/bindings/sound/wlf,wm8753.yaml | 62 +++++++++++++++++++
>  .../devicetree/bindings/sound/wm8753.txt      | 40 ------------

Guys,

You choose unusual bindings to convert to DT schema. It is fine but
honestly, less useful, with limited impact. This is an old, 12 year old
binding without users. Maybe it would be even removed by now...

I suggest converting ones which have a real impact - have users in DTS.
Otherwise you will be putting quite a lot of effort for no real gains...
because what is the difference between this binding being TXT and DT schema?

>  2 files changed, 62 insertions(+), 40 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8753.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/wm8753.txt
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof