linux-kernel - Re: [PATCH blktests] don't require modular null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyhVXdRN570SmcvMNtW-xL38siQ38PeYHrJgATxHyU4g0A@mail.gmail.com>
Date:   Sat, 15 Apr 2023 19:29:48 +0900
From:   Akinobu Mita <akinobu.mita@...il.com>
To:     "Shin'ichiro Kawasaki" <shinichiro@...tmail.com>
Cc:     chaitanyak@...dia.com, akpm@...ux-foundation.org, axboe@...nel.dk,
        hch@...radead.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH blktests] don't require modular null_blk for fault-injection

2023年4月12日(水) 12:05 Shin'ichiro Kawasaki <shinichiro@...tmail.com>:
>
> Akinobu, thanks for the patch, and sorry for this slow response.
>
> On Mar 30, 2023 / 01:21, Akinobu Mita wrote:
> > I'm trying to allow configuration of null_blk fault-injection via configfs.
> >
> > This blktests change changes null_blk fault-injection settings to be
> > configured via configfs instead of module parameters.
> > This allows null_blk fault-injection tests to run even if the null_blk is
> > built-in the kernel and not built as a module.
>
> It's good that the three test case can run with built-in null_blk.
>
> >
> > However, to keep the scripts simple, we will skip testing if the null_blk
> > does not yet support configuring fault-injection via configfs.
>
> Hmm, it means that blktests coverage will be lost on older kernels without the
> configfs support. Before this change, the test cases were not skipped on older
> kernel with loadable null_blk. After this patch, the test cases will be skipped.
>
> Can we cover both the new and old ways? When the null_blk set up with configfs
> fails, we can fallback to the old way with module parameters.
>
> For example, null_blk set up of block/014 can be like this:

OK, I'll update the tests and give it a try.