linux-kernel - Re: [PATCH] staging: rtl8192u: Remove functions rtl8192_wx_get_sens and rtl8192_wx_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023041559-peroxide-turmoil-9239@gregkh>
Date:   Sat, 15 Apr 2023 17:55:15 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Yogesh Hegde <yogi.kernel@...il.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Philipp Hortmann <philipp.g.hortmann@...il.com>
Subject: Re: [PATCH] staging: rtl8192u: Remove functions rtl8192_wx_get_sens
 and rtl8192_wx_set_sens

On Thu, Apr 13, 2023 at 08:50:12AM +0530, Yogesh Hegde wrote:
> Both of these functions depend on the function rf_set_sens, which is
> declared but never defined. Hence calling this function will cause an
> oops. Because there is no definition of the function, priv->rf_set_sens
> will always be NULL.
> 
> As a result rtl8192_wx_set_sens and rtl8192_wx_get_sens will always
> return -1.
> 
> Hence,
> * Removed function definition rf_set_sens
> * Removed usage of variable priv->rf_set_sens
> * Removed functions rtl8192_wx_get_sens and rtl8192_wx_set_sens
> * Cleaned up the variables sens and max_sens used in these functions
> 
> Suggested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>
> 
> Signed-off-by: Yogesh Hegde <yogi.kernel@...il.com>
> ---
>  drivers/staging/rtl8192u/r8192U.h    |  3 ---
>  drivers/staging/rtl8192u/r8192U_wx.c | 40 ++--------------------------
>  2 files changed, 2 insertions(+), 41 deletions(-)
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot