linux-kernel - Re: [PATCH] mm: make arch_has_descending_max_zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3c5d33f8-3669-4486-8986-d75fed8d882b@app.fastmail.com>
Date:   Sat, 15 Apr 2023 10:09:12 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "kernel test robot" <oliver.sang@...el.com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Andrew Morton" <akpm@...ux-foundation.org>
Cc:     oe-lkp@...ts.linux.dev, "kernel test robot" <lkp@...el.com>,
        linux-snps-arc@...ts.infradead.org, linux-mm@...ck.org,
        "Vineet Gupta" <vgupta@...nel.org>,
        "Mike Rapoport" <rppt@...nel.org>,
        "Nathan Chancellor" <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "David Hildenbrand" <david@...hat.com>,
        "Vlastimil Babka" <vbabka@...e.cz>, llvm@...ts.linux.dev,
        "Tom Rix" <trix@...hat.com>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        "Matthew Wilcox" <willy@...radead.org>,
        "Suren Baghdasaryan" <surenb@...gle.com>,
        "Naoya Horiguchi" <naoya.horiguchi@....com>,
        linux-kernel@...r.kernel.org, "Oscar Salvador" <osalvador@...e.de>
Subject: Re: [PATCH] mm: make arch_has_descending_max_zone_pfns() static

On Sat, Apr 15, 2023, at 08:42, kernel test robot wrote:
> Hello,
>
> kernel test robot noticed "kernel_BUG_at_lib/list_debug.c" on:
>
> commit: c31fe5eb2ec68f6d2331fabc924e0030cc6bb2b3 ("[PATCH] mm: make 
> arch_has_descending_max_zone_pfns() static")

Thanks for the report, that was a logic error on my end, the fix is:

--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1756,7 +1756,7 @@ static void __init free_area_init_memoryless_node(int nid)
  */
 static bool arch_has_descending_max_zone_pfns(void)
 {
-       return !IS_ENABLED(CONFIG_ARC_HAS_PAE40);
+       return IS_ENABLED(CONFIG_ARC) && !IS_ENABLED(CONFIG_ARC_HAS_PAE40);
 }
 
 /**

I'll send a replacement v2 that has this folded in.

    Arnd