linux-kernel - Re: [PATCH] dt-bindings: iio: adc: qcom,spmi-vadc: add 16 ratio of pre-scaling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Apr 2023 14:10:24 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Siddartha Mohanadoss <smohanad@...eaurora.org>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: qcom,spmi-vadc: add 16 ratio of
 pre-scaling

On Sun, 16 Apr 2023 14:31:42 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> Document value of 16 for pre-scaling, already used in DTS and supported
> by the Linux driver since long time:
> 
>   sm7225-fairphone-fp4.dtb: adc@...0: channel@8:qcom,pre-scaling: 'oneOf' conditional failed, one must be fixed:
>     10 was expected
>     16 is not one of [1, 3, 4, 6, 20, 8, 10]
>     81 was expected
> 
> Fixes: e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

I'm carrying an identical patch (though without the reordering) from Luca Weiss.
I thought as the whole series was very late in the cycle that it was unlikely
to be necessary to rush this in.

https://lore.kernel.org/all/20230414-pmi632-v1-5-fe94dc414832@z3ntu.xyz/

I see that patch is for the fairphone-fp3 adn this report is the fairphone-fp4.
Is that the reason this is a fix?

I'm also I'd like someone from driver side to confirm the drier supports this.
From a quick glance I'm not seeing 16 in what I think might be the related table.
https://elixir.bootlin.com/linux/latest/source/drivers/iio/adc/qcom-spmi-vadc.c#L126

Jonathan

> ---
>  Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> index f30114424b92..42077ca65747 100644
> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> @@ -101,7 +101,7 @@ patternProperties:
>          oneOf:
>            - items:
>                - const: 1
> -              - enum: [ 1, 3, 4, 6, 20, 8, 10 ]
> +              - enum: [ 1, 3, 4, 6, 8, 10, 16, 20 ]
>            - items:
>                - const: 10
>                - const: 81