linux-kernel - Re: [PATCH] hwmon: (k10temp): Check range scale when CUR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1afe95f1-cea1-418f-b9a1-23be6817157f@roeck-us.net>
Date:   Sun, 16 Apr 2023 07:35:14 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Babu Moger <babu.moger@....com>
Cc:     clemens@...isch.de, jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, Baski.Kannan@....com,
        yannick.hemery@...p.ovh.com
Subject: Re: [PATCH] hwmon: (k10temp): Check range scale when CUR_TEMP
 register is read-write

On Thu, Apr 13, 2023 at 04:39:58PM -0500, Babu Moger wrote:
> From: Babu Moger <Babu.Moger@....com>
> 
> Spec says, when CUR_TEMP_TJ_SEL == 3 and CUR_TEMP_RANGE_SEL == 0,
> it should use RangeUnadjusted is 0, which is (CurTmp*0.125 -49) C. The
> CUR_TEMP register is read-write when CUR_TEMP_TJ_SEL == 3 (bit 17-16).
> 
> Add the check to detect it.
> 
> Sensors command's output before the patch.
> $sensors
>  k10temp-pci-00c3
>  Adapter: PCI adapter
>  Tctl:         +76.6°C <- Wrong value
>  Tccd1:        +26.5°C
>  Tccd2:        +27.5°C
>  Tccd3:        +27.2°C
>  Tccd4:        +27.5°C
>  Tccd5:        +26.0°C
>  Tccd6:        +26.2°C
>  Tccd7:        +25.0°C
>  Tccd8:        +26.5°C
> 
> Sensors command's output after the patch.
> $sensors
>  k10temp-pci-00c3
>  Adapter: PCI adapter
>  Tctl:         +28.8°C <- corrected value
>  Tccd1:        +27.5°C
>  Tccd2:        +28.5°C
>  Tccd3:        +28.5°C
>  Tccd4:        +28.5°C
>  Tccd5:        +27.0°C
>  Tccd6:        +27.5°C
>  Tccd7:        +27.0°C
>  Tccd8:        +27.5°C
> 
> Signed-off-by: Babu Moger <babu.moger@....com>

Applied. Please update your e-mail address configuration to avoid the
following checkpatch message.

CHECK: From:/Signed-off-by: email comments mismatch: 'From: Babu Moger <Babu.Moger@....com>' != 'Signed-off-by: Babu Moger <babu.moger@....com>'

Thanks,
Guenter