linux-kernel - Re: [GIT PULL] x86/urgent for v6.3-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjOZgMu2VYBHMt-yFvurAqWsxLG8wh59km=B245CXRKxA@mail.gmail.com>
Date:   Sun, 16 Apr 2023 10:33:19 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     x86-ml <x86@...nel.org>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] x86/urgent for v6.3-rc7

On Sun, Apr 16, 2023 at 5:29 AM Borislav Petkov <bp@...en8.de> wrote:
>
> - Drop __init annotation from two rtc functions which get called after
>   boot is done, in order to prevent a crash

.. ahh, and our automation to catch these things didn't find it,
because they are only accessed from x86_wallclock_init(), which is
also __init.

So it all looked superficially good, except for the "oh, we saved them
into a data structure that _isn't_ init".

It would require automation much smarter than the one we have to catch
that kind of thing.

             Linus