[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7bdd986f-401e-08b6-6621-b680ef56198a@linaro.org>
Date: Sun, 16 Apr 2023 20:29:14 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jakob Hauser <jahau@...ketmail.com>,
Sebastian Reichel <sre@...nel.org>, Lee Jones <lee@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Beomho Seo <beomho.seo@...sung.com>,
Chanwoo Choi <cw00.choi@...sung.com>,
Stephan Gerhold <stephan@...hold.net>,
Raymond Hackley <raymondhackley@...tonmail.com>,
Pavel Machek <pavel@....cz>, Axel Lin <axel.lin@...ics.com>,
ChiYuan Huang <cy_huang@...htek.com>, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 0/9] Add RT5033 charger device driver
On 16/04/2023 14:44, Jakob Hauser wrote:
> This patchset adds the charger driver "rt5033-charger". It is part of the
> multifunction device rt5033. The patchset is based on an older version by
> Beomho Seo of March 2015. For more information on the history and setup of
> the patchset see the cover sheet of version v1, there is a link further down
> below the changelog.
>
> In patch 9 I didn't change the extcon phandle, I haven't received any answer
> on this.
>
> Changes in v2:
> - Rebased to linux-next (20230413), as suggested by Lee.
> - The v1 patch 3 "mfd: rt5033: Fix comments and style in includes" vanished
> as it got applied already.
> - Dropped the v1 patch 8 "power: supply: rt5033_charger: Make use of high
> impedance mode". The high impedance mode is kind of a sleep mode for power
> saving. It turned out that it might complicate a future implementation of
> an rt5033 flash LED driver. Therefore drop it for now. The high impedance
> mode could be added at a later date as a power saving improvement.
> - Patch 2: Changed variable name "data" back to original "dev_id".
> - New patch 5: Changed name of regulators to lowercase, as suggested by Rob.
> - Patch 6: In function "rt5033_charger_dt_init" replaced the devicetree units
> "uamp" to "microamp" and "uvolt" to "microvolt". However, I didn't change
> the unit names of the driver-internal variables in order to keep the
> variable names short. Let me know if you think they should be changed too.
> - Patch 9: Removed '|' after all "description" blocks in all three files.
> - Patch 9: In the example of "mfd/richtek,rt5033.yaml" changed "i2c@0"
> to "i2c".
> - Patch 9: In the example of "mfd/richtek,rt5033.yaml" removed the last part
> on the battery fuelgauge. It has its own I2C line and is therefore not a
> subsidiary of the rt5033 MFD driver.
> - Patch 9: Replaced units "uamp" by "microamp" and "uvolt" by "microvolt"
> in the example of "mfd/richtek,rt5033.yaml" and the file
> "power/supply/richtek,rt5033-charger.yaml".
> - Patch 9: Changed name of regulators to lowercase in
> "regulator/richtek,rt5033-regulator.yaml" and in the example of
> "mfd/richtek,rt5033.yaml" (related to patch 5).
> - Patch 9: Removed example from "regulator/richtek,rt5033-regulator.yaml".
> It is already part of the example in "mfd/richtek,rt5033.yaml".
Thanks for describing the changes. It's much more readable for us if
such complex changelog is put in each patch under --- .
Best regards,
Krzysztof
Powered by blists - more mailing lists