lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sun, 16 Apr 2023 15:38:44 +0800
From:   Junyan Ye <yejunyan@...t.edu.cn>
To:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        David Herrmann <dh.herrmann@...il.com>
Cc:     hust-os-kernel-patches@...glegroups.com,
        Junyan Ye <yejunyan@...t.edu.cn>,
        Dongliang Mu <dzm91@...t.edu.cn>,
        Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] hid: hid-core: Adjust indentation in hid_add_device

Smatch reported:
drivers/hid/hid-core.c:2750 hid_add_device() warn: inconsistent indenting

There is an extra space before the if statement and its braces.

Fix this warning by removing the whitespace to conform to the coding style.

Fixes: 3c86726cfe38 ("HID: make .raw_request mandatory")
Signed-off-by: Junyan Ye <yejunyan@...t.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
---
 drivers/hid/hid-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 22623eb4f72f..80fc2eed6383 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2747,10 +2747,10 @@ int hid_add_device(struct hid_device *hdev)
 	/*
 	 * Check for the mandatory transport channel.
 	 */
-	 if (!hdev->ll_driver->raw_request) {
+	if (!hdev->ll_driver->raw_request) {
 		hid_err(hdev, "transport driver missing .raw_request()\n");
 		return -EINVAL;
-	 }
+	}
 
 	/*
 	 * Read the device report descriptor once and use as template
-- 
2.25.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ