linux-kernel - Re: [PATCH] accel/habanalabs: remove variable gaudi_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf12tq7-r7Ej2mwWruQHOvk2d1Z2S_BEVoKF45HsJjfZBDw@mail.gmail.com>
Date:   Sun, 16 Apr 2023 11:35:43 +0300
From:   Oded Gabbay <ogabbay@...nel.org>
To:     Tom Rix <trix@...hat.com>
Cc:     gregkh@...uxfoundation.org, osharabi@...ana.ai, talcohen@...ana.ai,
        dhirschfeld@...ana.ai, obitton@...ana.ai,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] accel/habanalabs: remove variable gaudi_irq_name

On Tue, Apr 11, 2023 at 5:09 PM Tom Rix <trix@...hat.com> wrote:
>
> gcc with W=1 reports
> drivers/accel/habanalabs/gaudi/gaudi.c:117:19: error:
>   ‘gaudi_irq_name’ defined but not used [-Werror=unused-const-variable=]
>   117 | static const char gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STRING_LEN] = {
>       |                   ^~~~~~~~~~~~~~
>
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/accel/habanalabs/gaudi/gaudi.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/accel/habanalabs/gaudi/gaudi.c b/drivers/accel/habanalabs/gaudi/gaudi.c
> index a29aa8f7b6f3..a1697581c218 100644
> --- a/drivers/accel/habanalabs/gaudi/gaudi.c
> +++ b/drivers/accel/habanalabs/gaudi/gaudi.c
> @@ -114,13 +114,6 @@ static u32 gaudi_stream_master[GAUDI_STREAM_MASTER_ARR_SIZE] = {
>         GAUDI_QUEUE_ID_DMA_1_3
>  };
>
> -static const char gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STRING_LEN] = {
> -               "gaudi cq 0_0", "gaudi cq 0_1", "gaudi cq 0_2", "gaudi cq 0_3",
> -               "gaudi cq 1_0", "gaudi cq 1_1", "gaudi cq 1_2", "gaudi cq 1_3",
> -               "gaudi cq 5_0", "gaudi cq 5_1", "gaudi cq 5_2", "gaudi cq 5_3",
> -               "gaudi cpu eq"
> -};
> -
>  static const u8 gaudi_dma_assignment[GAUDI_DMA_MAX] = {
>         [GAUDI_PCI_DMA_1] = GAUDI_ENGINE_ID_DMA_0,
>         [GAUDI_PCI_DMA_2] = GAUDI_ENGINE_ID_DMA_1,
> --
> 2.27.0
>

Reviewed-by: Oded Gabbay <ogabbay@...nel.org>
Applied to -next
Thanks,
Oded