[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3c72e720-d636-d929-658b-75c98b575292@linaro.org>
Date: Mon, 17 Apr 2023 17:46:51 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Arnaud Vrac <avrac@...ebox.fr>, Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8998: add blsp spi nodes
On 17/04/2023 17:41, Arnaud Vrac wrote:
> Signed-off-by: Arnaud Vrac <avrac@...ebox.fr>
Missing commit msg.
> ---
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 309 ++++++++++++++++++++++++++++++++++
> 1 file changed, 309 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index b150437a83558..41c8bb44d1fb1 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -1228,6 +1228,57 @@ blsp1_i2c6_sleep: blsp1-i2c6-sleep-state {
> drive-strength = <2>;
> bias-pull-up;
> };
> +
> + blsp1_spi_b_default: blsp1-spi_b-default {
No underscores in node names, missing suffix.
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
Best regards,
Krzysztof
Powered by blists - more mailing lists