[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5d753a8a-b979-43f6-a403-8a51f69bac29@sirena.org.uk>
Date: Mon, 17 Apr 2023 16:58:33 +0100
From: Mark Brown <broonie@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Banajit Goswami <bgoswami@...cinc.com>,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ASoC: codecs: wcd934x: Simplify with dev_err_probe
On Mon, Apr 17, 2023 at 05:43:03PM +0200, Krzysztof Kozlowski wrote:
> On 17/04/2023 17:33, Mark Brown wrote:
> > On Mon, Apr 17, 2023 at 04:14:51PM +0200, Krzysztof Kozlowski wrote:
> >> - if (IS_ERR(wcd->if_regmap)) {
> >> - dev_err(dev, "Failed to allocate ifc register map\n");
> >> - return PTR_ERR(wcd->if_regmap);
> >> - }
> >> + if (IS_ERR(wcd->if_regmap))
> >> + return dev_err_probe(dev, PTR_ERR(wcd->if_regmap),
> >> + "Failed to allocate ifc register map\n");
> > This is a functional change.
> Hmm... I don't see it. Return value is the same, same message is
> printed, same condition. Did I make some copy-paste error?
You've replaced an unconditional dev_err() with dev_err_probe().
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists