linux-kernel - Re: [PATCH] misc: hpilo: Fix use after free bug in ilo_remove due to race condition with ilo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023041756-scoop-splendor-0e01@gregkh>
Date:   Mon, 17 Apr 2023 19:43:35 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Zheng Wang <zyytlz.wz@....com>
Cc:     matt.hsiao@....com, arnd@...db.de, linux-kernel@...r.kernel.org,
        hackerzheng666@...il.com, 1395428693sheep@...il.com,
        alex000young@...il.com
Subject: Re: [PATCH] misc: hpilo: Fix use after free bug in ilo_remove due to
 race condition with ilo_open

On Tue, Apr 18, 2023 at 12:52:46AM +0800, Zheng Wang wrote:
> --- a/drivers/misc/hpilo.h
> +++ b/drivers/misc/hpilo.h
> @@ -62,6 +62,7 @@ struct ilo_hwinfo {
>  	spinlock_t fifo_lock;
>  
>  	struct cdev cdev;
> +	struct kref refcnt;

You now have 2 different structures doing reference counting logic on
the same structure.  That's just not ok at all, and is totally broken.

greg k-h