linux-kernel - Re: [BUG REPORT] arch/x86/include/asm/uaccess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230417181417.GHZD2MeRSuMWUPEU3V@fat_crate.local>
Date:   Mon, 17 Apr 2023 20:14:17 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Willy Tarreau <w@....eu>
Cc:     Jingbo Xu <jefflexu@...ux.alibaba.com>, tglx@...utronix.de,
        mingo@...hat.com, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...or.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [BUG REPORT] arch/x86/include/asm/uaccess_64.h:119: Error: junk
 at end of line

On Sun, Apr 16, 2023 at 10:36:36AM +0200, Willy Tarreau wrote:
> ...
> So it just means that the support for the "U" suffix on numbers was
> added in binutils 2.27 and the "L" suffix on numbers was added somewhere
> between 2.27 and 2.29.

Thanks for that - I'd like to document this once I've hashed out with
the toolchain person the proper binutils versions which got this
support. But that'll come later.

> And given that there's a single occurrence of all this in the whole tree,
> that's why I'm proposing to just get back to the good old (1 << 0) instead
> of BIT(0).

Yeah, we have those UC() macro things but they don't work in inline asm
in C code. So yeah, pls do the thing you're suggesting.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette