linux-kernel - Re: [PATCH v3 0/3] mailbox: Allow direct registration to a channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABb+yY0iO3FPMi6WHaHio+vsjXWiN-x85kCXyjPZ6EWZgmnwgg@mail.gmail.com>
Date:   Mon, 17 Apr 2023 14:08:45 -0500
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     Elliot Berman <quic_eberman@...cinc.com>
Cc:     Sudeep Holla <sudeep.holla@....com>, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 0/3] mailbox: Allow direct registration to a channel

On Mon, Apr 10, 2023 at 11:17 AM Elliot Berman <quic_eberman@...cinc.com> wrote:
>
> Two mailbox controllers have channel/client binding mechanisms that are
> controller-specific and not using the devicetree binding mechanisms. Mailbox
> channel/client is conceptually done in two steps: selecting the channel
> and binding the selected to channel to a client. Channel selection is sometimes
> controller specific (pcc and omap are examples). The channel/client binding
> code is all the same.
>
> This small series de-duplicates and refactors the channel/client binding
> into a common framework function: "mbox_bind_client" which all of the
> channel selection mechanisms can use.
>
> I found this duplicate code while working on the support for Gunyah hypervisor
> message queues [1]. I've only been able to compile-test omap-mailbox and pcc,
> however it is a straightforward conversion here.
>
> [1]: https://lore.kernel.org/all/20230120224627.4053418-9-quic_eberman@quicinc.com/
>
> Chagnes since v2:
>  - Fix warnings in drivers/mailbox/pcc.c reported by lkp@...el.com
>
> Changes since v1:
>  - Rebase to https://git.linaro.org/landing-teams/working/fujitsu/integration.git/log/?h=mailbox-for-next
>  - Add Tested-By from Sudeep (thanks!)
>
> Elliot Berman (3):
>   mailbox: Allow direct registration to a channel
>   mailbox: omap: Use mbox_bind_client
>   mailbox: pcc: Use mbox_bind_client
>
>  drivers/mailbox/mailbox.c      | 96 ++++++++++++++++++++++++----------
>  drivers/mailbox/omap-mailbox.c | 22 ++------
>  drivers/mailbox/pcc.c          | 84 +++++++++++++++--------------
>  include/linux/mailbox_client.h |  1 +
>  4 files changed, 118 insertions(+), 85 deletions(-)
>
Seems fine. Will pick these up for the coming merge window.

Thanks.