linux-kernel - Re: [PATCH] drm/amd/display: remove unused variable oldest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_OHu7kJGvTVg_oDMadqQFBrhFAZBM9H76y6tiYNsWT+4Q@mail.gmail.com>
Date:   Mon, 17 Apr 2023 15:28:21 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Tom Rix <trix@...hat.com>
Cc:     harry.wentland@....com, sunpeng.li@....com,
        Rodrigo.Siqueira@....com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com,
        daniel@...ll.ch, HaoPing.Liu@....com, aric.cyr@....com,
        qingqing.zhuo@....com, hanghong.ma@....com, felipe.clark@....com,
        Dillon.Varone@....com, Mike.Hsieh@....com,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: remove unused variable oldest_index

Applied.  Thanks!

On Fri, Apr 14, 2023 at 11:08 AM Tom Rix <trix@...hat.com> wrote:
>
> cpp_check reports
> drivers/gpu/drm/amd/display/modules/freesync/freesync.c:1143:17: style: Variable
>   'oldest_index' is assigned a value that is never used. [unreadVariable]
>    oldest_index = 0;
>                 ^
>
> This variable is not used so remove.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> index 5c41a4751db4..5798c0eafa1f 100644
> --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> @@ -1137,10 +1137,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
>
>         if (in_out_vrr->supported &&
>                         in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE) {
> -               unsigned int oldest_index = plane->time.index + 1;
> -
> -               if (oldest_index >= DC_PLANE_UPDATE_TIMES_MAX)
> -                       oldest_index = 0;
>
>                 last_render_time_in_us = curr_time_stamp_in_us -
>                                 plane->time.prev_update_time_in_us;
> --
> 2.27.0
>